feat(dms): add new resource to restart nodes #7622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zippo-Wang
force-pushed
the
feat_instance_restart
branch
4 times, most recently
from
3a34f85 to
797f907
Compare
Lance52259
reviewed
Aug 26, 2025
| * `region` - (Optional, String, ForceNew) Specifies the region in which to restart the RocketMQ instance. | ||
| If omitted, the provider-level region will be used. Changing this parameter will create a new resource. | ||
|
|
||
| * `instance_id` - (Required, String, NonUpdatable) Specifies the ID of the RocketMQ instance to be restarted. |
There was a problem hiding this comment.
Suggested change
| * `instance_id` - (Required, String, NonUpdatable) Specifies the ID of the RocketMQ instance to be restarted. | |
| * `instance_id` - (Required, String, NonUpdatable) Specifies the ID of the RocketMQ instance to which nodes belong. |
Comment on lines
49
to
55
| ## Import | ||
|
|
||
| The RocketMQ instance restart resource cannot be imported. | ||
|
|
||
| ## Timeouts | ||
|
|
||
| This resource does not support timeout configuration. |
There was a problem hiding this comment.
Suggested change
| ## Import | |
| The RocketMQ instance restart resource cannot be imported. | |
| ## Timeouts | |
| This resource does not support timeout configuration. |
Extra contents
Comment on lines
85
to
86
| // Add nodes parameter to request body if specified | ||
| if nodesRaw := d.Get("nodes").([]interface{}); len(nodesRaw) > 0 { |
There was a problem hiding this comment.
Suggested change
| // Add nodes parameter to request body if specified | |
| if nodesRaw := d.Get("nodes").([]interface{}); len(nodesRaw) > 0 { |
the behavior of parameter nodes is Required, these codes are unnecessary.
| } | ||
| } | ||
|
|
||
| func resourceDmsRocketMQInstanceRestartCreate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { |
There was a problem hiding this comment.
function name do not include DMSRocketMQ because of the package is already names rocketmq
Zippo-Wang
force-pushed
the
feat_instance_restart
branch
5 times, most recently
from
89c44b3 to
265ff09
Compare
Zippo-Wang
force-pushed
the
feat_instance_restart
branch
from
265ff09 to
60bf7ff
Compare
|
/approve |
github-ci-robot
added
LGTM
github-ci-robot
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add new resource to restart nodes
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
1.apply
2.plan
3.destroy
4.UT