-
Notifications
You must be signed in to change notification settings - Fork 142
[OpenVINO]Add Kontext support #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
openvino-dev-samples
wants to merge
11
commits into
huggingface:main
Choose a base branch
from
openvino-dev-samples:kontext
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ebe5be2
add kontext support
openvino-dev-samples d2a5a92
add kontext support
openvino-dev-samples 024ac2d
add test case
openvino-dev-samples c365139
reformat
openvino-dev-samples 051a8da
Apply style fixes
github-actions[bot] c49252f
add diffusion and export test
openvino-dev-samples 8459565
rebase the export cli test
openvino-dev-samples 2c7e1de
add quantize test case
openvino-dev-samples c160e7f
delete cli export test
openvino-dev-samples 0d5d3ab
Merge branch 'huggingface:main' into kontext
openvino-dev-samples 1e37d3d
support diffusers 3.5
openvino-dev-samples File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe adding this here is not enough for the test for this model to be run. Could you please add changes to
test_diffusion.py
,test_exporters_cli.py
andtest_quantization.py
similar to how it was done in this PR for example #1106?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @IlyasMoutawwakil my patch depends on the fix for diffusers lib, could you help to check ?
huggingface/diffusers#11875
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to wait for diffusers to do an entire release to test this. You can do the same as sana by using DiffusionPipeline instead of AutoPipelineForxxx https://github.com/huggingface/optimum-intel/blob/main/tests/openvino/test_diffusion.py#L146 for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but how about in CLI export test case ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cli export test should pass as it uses the correct class name https://github.com/huggingface/optimum/blob/ec756fdd00543d3a93458fafbcdf5abbb17b61ba/optimum/exporters/tasks.py#L2159 🙂
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E ImportError: cannot import name 'FluxKontextPipeline' from 'diffusers'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's exactly the motive for adding this model anyway ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So your suggestion is adding the model after 0.34.0 version of diffuser released, am i right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or install diffusers from source.. for testing sake.
but bear in mind that python packages can't be released with a "git+https...." dependency, so we will have to wait for a diffusers release if you want this in the next optimum-intel release.