Skip to content

Bump sccache to 0.10.0 #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

Bump sccache to 0.10.0 #3179

merged 2 commits into from
Apr 18, 2025

Conversation

alvarobartt
Copy link
Member

What does this PR do?

This PR bumps the version for sscache to 0.10.0 for the TRT-LLM integration, due to the recent deprecation of the former caching as per https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts which was made effective yesterday (April 15th, 2025).

This PR ensures that the installed sccache version is 0.10.0 or higher, and renames the environment variable ACTIONS_CACHE_URL to ACTIONS_RESULTS_URL as per mozilla/sccache#2351.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@mfuntowicz, @Hugoch (based on the recent commits to those files, in particular to the TRT-LLM backend) or @XciD

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Narsil Narsil merged commit 95ccba3 into main Apr 18, 2025
32 checks passed
@Narsil Narsil deleted the bump-sccache branch April 18, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants