-
-
Notifications
You must be signed in to change notification settings - Fork 376
Update zh.yaml #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update zh.yaml #989
Conversation
add page title of reset pw
title.
Fix Moderator tag
WalkthroughThis change updates the Simplified Chinese localization file by correcting the formatting of a placeholder in an existing string, modifying the translation for "Lucky," and adding two new localization keys: "user_lostpass_mail_sent" and "user_lostpass_with_code" with their respective translations. No other functional or structural changes are included. Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/ui-default/locales/zh.yaml (4)
6-6
: Align translation of 'moderator' with existing term
Earlier in this file'Moderator'
is rendered as管理员
, but here the translation uses管理者之一
. For consistency (and to match UI terminology), consider using管理员
instead of管理者
.
1010-1010
: Add missing punctuation and context
The translation'密码重置邮件已发送'
omits the trailing full stop and the target ("到您的电子邮箱") found in similar entries. Consider updating to'密码重置邮件已发送到您的电子邮箱。'
for clarity and consistency.
1012-1012
: Clarify translation to include 'with code'
The keyuser_lostpass_with_code
implies a password reset flow with a code, but'重置密码'
may be too generic. You might want to translate it as'使用验证码重置密码'
to preserve context.
1098-1098
: Ensure proper quoting for key with colon
Keys containing spaces and punctuation (e.g.Your role:
) should be quoted in YAML to avoid parsing issues. Please confirm this line is wrapped in quotes like:'Your role:': '您的角色'
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/ui-default/locales/zh.yaml
(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
packages/ui-default/locales/zh.yaml (1)
544-544
: Approve translation adjustment for 'Lucky'
The change from手气不错
to试试手气
aligns well with the intended UI label ("Try your luck") and fits established patterns.
Do not edit it on web! |
手气不错真的要改吗,google 都是手气不错 |
我看他是随机抽题,就顺手给改了 |
Sorry, it won’t happen again. |
update some translation, fix moderator tag
Summary by CodeRabbit
New Features
Bug Fixes