Skip to content

make a couple of private functions static to silence CA1822 analyzer warnings #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2021
Merged

make a couple of private functions static to silence CA1822 analyzer warnings #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ICSharpCode.SharpZipLib/Zip/ZipEntry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,7 +1125,7 @@ internal void ProcessExtraData(bool localHeader)
}
}

private DateTime? GetDateTime(ZipExtraData extraData)
private static DateTime? GetDateTime(ZipExtraData extraData)
{
// Check for NT timestamp
// NOTE: Disable by default to match behavior of InfoZIP
Expand Down
2 changes: 1 addition & 1 deletion src/ICSharpCode.SharpZipLib/Zip/ZipFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1904,7 +1904,7 @@ public void AddDirectory(string directoryName)
/// Check if the specified compression method is supported for adding a new entry.
/// </summary>
/// <param name="compressionMethod">The compression method for the new entry.</param>
private void CheckSupportedCompressionMethod(CompressionMethod compressionMethod)
private static void CheckSupportedCompressionMethod(CompressionMethod compressionMethod)
{
if (compressionMethod != CompressionMethod.Deflated && compressionMethod != CompressionMethod.Stored && compressionMethod != CompressionMethod.BZip2)
{
Expand Down