transpile: add support for CTypeKind::UnaryTypes in --translate-const-macros conservative
#1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Kind::Size` (`size_t`) This is currently implemented in `fn bubble_expr_types`, as that does a traversal over all types to fix them up for clang 15. But that's likely not where we want to do this, as this isn't related to clang 15 fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizeofisn't translated asCTypeKind::Size#1345.This adds support for
CTypeKind::UnaryTypein--translate-const-macros conservative. Previously, theseUnaryTypes received the non-portable type ofc_ulong, which failed to compile since their Rust translations likemem::size_ofreturnusize. On the C side,sizeofexpressions are indeed supposed to have typesize_t, so they should get the portable typeCTypeKind::Size. This adds this type infn bubble_expr_types, which might not be the right place to do so, since that's currently for fixing up the types from clang 15. This type fix could instead be moved to a separate pass as well. In doing so, I also cleaned up some minor stuff infn bubble_expr_types, which should be easier to review if you ignore whitespace changes.