Use generics, instead of big.Float and big.ParseFloat #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… check for specific errors (errorlint)
Bump module name to `v2`, because it has incompatible changes. Args of `NewThresholds()` must be type of `cmp.Ordered` and it can't be `nil`. Two new methods added to `Thresholds` type: ``` UseWarning(useMin, useMax bool) UseCritical(useMin, useMax bool) ``` `useMin` defines is `WarningMin` or `CriticalMin` defined or not. `useMax` does the same for `WarningMax` or `CriticalMax`. So instead of calling `NewThresholds()` with `nil`s, now we should use `UseWarning()` and/or `UseCritical()`.
There is no `SetWarn()` and `SetCrit()` methods. We use `SetThresholds()` and `NewThresholds()` instead.
because it automatically uses same type as Value.
which allows replace the default OK message at any time later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump module name to
v2, because it has incompatible changes.Args of
NewThresholds()must be type ofcmp.Orderedand it can't benil.Two new methods added to
Thresholdstype:useMindefines isWarningMinorCriticalMindefined or not.useMaxdoes the same forWarningMaxorCriticalMax. So instead of callingNewThresholds()withnils, now we should useUseWarning()and/orUseCritical().