Skip to content

feat(modbus_server): add modbus_server io plugins #16669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iiacoban42
Copy link

@iiacoban42 iiacoban42 commented Mar 20, 2025

Summary

This PR introduces input and output plugins designed to interact with a Modbus server. It ensures that both plugins handle various data types to enable producing metrics from incoming requests to Modbus server, as well as writing metrics to Modbus server.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16667

@iiacoban42 iiacoban42 force-pushed the feat/modbus-server-plugins branch from 7379396 to 285c106 Compare March 20, 2025 16:26
@iiacoban42 iiacoban42 changed the title Feat/modbus server plugins feat(modbus_server): add modbus_server io plugins Mar 20, 2025
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Mar 20, 2025
@srebhan
Copy link
Member

srebhan commented Mar 21, 2025

@iiacoban42 how is this related to the existing modbus plugin?

@srebhan srebhan self-assigned this Mar 21, 2025
@iiacoban42
Copy link
Author

The existing modbus acts as a modbus client sending requests wheres modbus_servers implements the server side listening for requests.

In terms of code, modbus_server reuses the same type conversions as the modbus client plugin with a few additions used to convert types to bytes.

@iiacoban42 iiacoban42 force-pushed the feat/modbus-server-plugins branch 4 times, most recently from b8fec18 to 6fc5e33 Compare March 25, 2025 08:23
@iiacoban42 iiacoban42 force-pushed the feat/modbus-server-plugins branch from 6fc5e33 to 9228afe Compare March 25, 2025 09:07
@srebhan
Copy link
Member

srebhan commented Mar 31, 2025

@iiacoban42 I think I first need to better understand the use-cases of those plugins. Let's discuss those in the issue before continuing here...

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented May 1, 2025

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 2.59 % for linux amd64 (new size: 293.1 MB, nightly size 285.7 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modbus server input and output plugins
2 participants