Skip to content

test(testutil): Performance and code quality improvements on metric #17011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

skartikey
Copy link
Contributor

Summary

Simplified loops and reduced redundant checks in lessFunc.
Optimized slice handling with preallocation and copy() in metric diff functions.
Removed unnecessary variable assignments for cleaner returns.
Avoided repeated method calls by caching results.
Preallocated map capacities for better performance.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @skartikey! A few comments, most of them suggest to use slices.Clone instead of manually cloning the tags and fields...

skartikey and others added 2 commits May 27, 2025 12:58
Co-authored-by: Sven Rebhan <[email protected]>
Co-authored-by: Sven Rebhan <[email protected]>
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan changed the title refactor(test): Performance and code quality Improvements on metric testutil test(testutil): Performance and code quality improvements on metric May 28, 2025
@telegraf-tiger telegraf-tiger bot added the test label May 28, 2025
@srebhan srebhan assigned mstrandboge and unassigned srebhan May 28, 2025
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 28, 2025
@mstrandboge mstrandboge merged commit edfb5e9 into influxdata:master Jun 2, 2025
29 checks passed
@github-actions github-actions bot added this to the v1.35.0 milestone Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants