feat(agent): Add debounce for watch events #17048
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
the
feat
skartikey
reviewed
May 23, 2025
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
|
@neelayu Could you please rebase your branch on top of |
Co-authored-by: skartikey <[email protected]>
|
Yes. I think I added it to check if tests were passing or not. Rebased now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a debounce mechanism for configuration file watching that batches multiple file changes into a single reload operation.
Changes Made
--watch-debounce-intervalCLI flag to configure the debounce duration (default: 0s for backward compatibility)watchLocalConfig()function that:SIGHUP) after the timer expires without interruptionreloadPendingflag to prevent unnecessary operationsBehavior Change
Usage Example
# Enable debouncing with 5-second wait period telegraf --config-directory /configs --watch-config=notify --watch-debounce-interval=5sChecklist
Related issues
resolves #17047
Essentially, the config watcher will wait for 10 seconds after the last change to the config directory before reloading the config. This is useful when you have multiple files in a directory and you want to avoid reloading the config multiple times if they are changed in quick succession.