-
Notifications
You must be signed in to change notification settings - Fork 121
Pause media playback when swiping to the next submission #3393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pause media playback when swiping to the next submission #3393
Conversation
refs: MBL-18859 affects: Teacher release note: none test plan: See ticket for test submissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA + 1
Minor clarification: the media actually stops, not just pauses (which is strange, since the https://developer.apple.com/documentation/avfoundation/avplayer/pause() method should just pause.)
But I think it's good enough or maybe even preferred.
One somewhat related finding: rotating to landscape on iPad (@ iOS 17) the video stops, but this is not a regression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code +1
Core/CoreTests/Common/Extensions/UIKit/UIViewControllerExtensionsTests.swift
Show resolved
Hide resolved
Teacher/Teacher/SpeedGrader/StudentPager/ViewModel/SpeedGraderViewModel.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA +1
Tested on iPhone XS, iOS 18.3.1
…-switching-assignments-in-SpeedGrader
What's new?
didTransitionTo
method in SpeedGraderViewModel.refs: MBL-18859
affects: Teacher
release note: none
test plan: See ticket for test submissions.
Checklist