Add paddings to SubmissionViewer #3409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-18849 affects: Teacher release note: none
Teacher Build QR Code: |
petkybenedek
requested review from
vargaat,
szabinst,
rh12,
ndrsszsz and
suhaibabsi-inst
as code owners
rh12
reviewed
Jun 3, 2025
| @@ -65,7 +66,9 @@ struct SubmissionViewer: View { | |||
| Text("This student's responses are hidden because this assignment is anonymous.", bundle: .teacher) | |||
| Spacer() | |||
| } | |||
| .font(.regular16).foregroundColor(.textDarkest) | |||
| .font(.regular16) | |||
| .padding(InstUI.Styles.Padding.standard.rawValue) | |||
There was a problem hiding this comment.
We could use the standard value directly:
.paddingStyle(.all, .standard) or .paddingStyle(.horizontal, .standard)
(For some reason .paddingStyle(.standard) doesn't work, this could be fixed later)
Same for other usage below
There was a problem hiding this comment.
Swift will not figure out which parameter was specified between multiple, non-named parameters with default values. Here's a short example without type inference:
func testFunction(_ message: String = "", _ statusCode: Int = 200) {
print("Test Function Called: \(message) with status code: \(statusCode)")
}
testFunction(200) // Cannot convert value of type 'Int' to expected argument type 'String'
testFunction()
testFunction("Open in Safari")
testFunction("Open in Safari", 200)
I fixed it, .paddingStyle(.standard) can be used now.
rh12
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: MBL-18849
affects: Teacher
release note: none
test plan:
Screenshots
Checklist