Skip to content

Add ability to download libwebrc-bin from branch for Desktop #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

turtletongue
Copy link

@turtletongue turtletongue commented Jul 8, 2025

Part of #224

Synopsis

There is a need to run CI on pre-release branches of the libwebrtc-bin. Artifacts from last libwebrtc-bin CI run should be accessible as easy as release artifacts.

Solution

A release or a branch is selected based on WEBRTC_BRANCH environment variable. Empty WEBRTC_BRANCH is used in release builds and non-empty WEBRTC_BRANCH ensures use of artifacts from last green CI of specific branch. Downloading of artifacts is based on GitHub API, so GH_TOKEN environment variable must also be set if WEBRTC_BRANCH is not empty.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@turtletongue turtletongue added k::toolchain Applies to changes of project toolchain platform::windows Specific to Windows platform platform::macos Specific to macOS platform platform::linux Specific to Linux platform feature New feature or request k::testing Related to testing and/or automated tests labels Jul 8, 2025
@turtletongue turtletongue self-assigned this Jul 8, 2025
@turtletongue
Copy link
Author

FCM

Allow downloading `libwebrc-bin` from branch for desktop targets in `libwebrtc-sys` crate (#236, #224)

@turtletongue turtletongue marked this pull request as ready for review July 8, 2025 14:05
@turtletongue turtletongue marked this pull request as draft July 9, 2025 11:03
@turtletongue turtletongue requested a review from evdokimovs July 9, 2025 11:49
@turtletongue turtletongue marked this pull request as ready for review July 9, 2025 11:51
@evdokimovs evdokimovs requested a review from alexlapa July 17, 2025 11:48
@turtletongue turtletongue requested a review from evdokimovs July 23, 2025 13:33
@evdokimovs evdokimovs requested a review from alexlapa July 29, 2025 13:12
@turtletongue turtletongue requested a review from alexlapa July 31, 2025 14:00
Copy link

@alexlapa alexlapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recheck after my changes and send to tyronron if everything is ok.

@turtletongue turtletongue requested a review from tyranron August 1, 2025 11:14
@tyranron tyranron force-pushed the pre-release-libwebrtc-build branch from 9131c39 to 33dcae8 Compare August 1, 2025 16:17
@tyranron tyranron added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base and removed k::testing Related to testing and/or automated tests labels Aug 1, 2025
@tyranron tyranron enabled auto-merge (squash) August 1, 2025 16:19
@tyranron tyranron merged commit 0f9f227 into instrumentisto:main Aug 1, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::toolchain Applies to changes of project toolchain platform::linux Specific to Linux platform platform::macos Specific to macOS platform platform::windows Specific to Windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants