forked from flutter-webrtc/flutter-webrtc
-
Notifications
You must be signed in to change notification settings - Fork 3
Add ability to download libwebrc-bin from branch for Desktop #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tyranron
merged 27 commits into
instrumentisto:main
from
turtletongue:pre-release-libwebrtc-build
Aug 1, 2025
Merged
Add ability to download libwebrc-bin from branch for Desktop #236
tyranron
merged 27 commits into
instrumentisto:main
from
turtletongue:pre-release-libwebrtc-build
Aug 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FCM
|
…r-webrtc into pre-release-libwebrtc-build
evdokimovs
approved these changes
Jul 17, 2025
alexlapa
requested changes
Jul 23, 2025
…r-webrtc into pre-release-libwebrtc-build
evdokimovs
requested changes
Jul 23, 2025
…r-webrtc into pre-release-libwebrtc-build
alexlapa
requested changes
Jul 31, 2025
alexlapa
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recheck after my changes and send to tyronron if everything is ok.
9131c39
to
33dcae8
Compare
tyranron
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvement of existing features or bugfix
feature
New feature or request
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
k::toolchain
Applies to changes of project toolchain
platform::linux
Specific to Linux platform
platform::macos
Specific to macOS platform
platform::windows
Specific to Windows platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #224
Synopsis
There is a need to run CI on pre-release branches of the
libwebrtc-bin
. Artifacts from lastlibwebrtc-bin
CI run should be accessible as easy as release artifacts.Solution
A release or a branch is selected based on
WEBRTC_BRANCH
environment variable. EmptyWEBRTC_BRANCH
is used in release builds and non-emptyWEBRTC_BRANCH
ensures use of artifacts from last green CI of specific branch. Downloading of artifacts is based on GitHub API, soGH_TOKEN
environment variable must also be set ifWEBRTC_BRANCH
is not empty.Checklist
k::
labels applied