Skip to content

Add ability to download libwebrc-bin from branch for mobile #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

turtletongue
Copy link

@turtletongue turtletongue commented Jul 9, 2025

Part of #224

Synopsis

There is a need to run CI on pre-release branches of the libwebrtc-bin. Artifacts from last libwebrtc-bin CI run should be accessible as easy as release artifacts.

Solution

A release or a branch is selected based on WEBRTC_BRANCH environment variable. Empty WEBRTC_BRANCH is used in release builds and non-empty WEBRTC_BRANCH ensures use of artifacts from last green CI of specific branch. Downloading of artifacts is based on GitHub API, so GH_TOKEN environment variable must also be set if WEBRTC_BRANCH is not empty.

Example of usage for Android:

WEBRTC_BRANCH=136.0.7103.113 GH_TOKEN=put_token_here make flutter.test.mobile platform=android

Example of usage for IOS:

WEBRTC_BRANCH=136.0.7103.113 GH_TOKEN=put_token_here make flutter.test.mobile platform=ios device=...

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@turtletongue turtletongue added k::toolchain Applies to changes of project toolchain plarform::android Specific to Android platform platform::ios Specific to iOS platform feature New feature or request k::testing Related to testing and/or automated tests labels Jul 9, 2025
@turtletongue turtletongue self-assigned this Jul 9, 2025
@turtletongue
Copy link
Author

FCM

Allow downloading `libwebrc-bin` from branch for mobile targets in `libwebrtc-sys` crate (#238, #224)

@turtletongue turtletongue marked this pull request as ready for review July 9, 2025 15:44
@turtletongue turtletongue requested a review from evdokimovs July 9, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request k::testing Related to testing and/or automated tests k::toolchain Applies to changes of project toolchain plarform::android Specific to Android platform platform::ios Specific to iOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant