Skip to content

del: removed markdown files for migration to docs #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

francis-tanyx
Copy link

@francis-tanyx francis-tanyx commented Apr 2, 2025

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/automated-self-checkout/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

  • removed the readme files from common-service, pipeline-server and retail-data-visualization after migrating to Documentation repo

Issue this PR will close

close: Issue 51 in Documentation Repo

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

  • By running the github-pages.yml workflow in Documentation repo to see the changes being reflected.

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/automated-self-checkout )

@francis-tanyx
Copy link
Author

francis-tanyx commented Apr 2, 2025

@antoniomtz @NeethuES-intel @ejlee3

Recreated the PR to solve the merge conflict. Here is the new PR for docs migration issue
intel-retail/documentation#51

@NeethuES-intel
Copy link
Contributor

@francis-tanyx can you add more details to this PR - label, how to test, PR issue etc. Similar to #677

@francis-tanyx
Copy link
Author

@francis-tanyx can you add more details to this PR - label, how to test, PR issue etc. Similar to #677

okay done

@NeethuES-intel
Copy link
Contributor

@francis-tanyx can you add more details to this PR - label, how to test, PR issue etc. Similar to #677

okay done

@francis-tanyx CodeQl, trivy code scan & trivy image scan are all failing. Can you resolve these or check what is happening ?

@NeethuES-intel
Copy link
Contributor

@francis-tanyx can you add more details to this PR - label, how to test, PR issue etc. Similar to #677

okay done

@francis-tanyx CodeQl, trivy code scan & trivy image scan are all failing. Can you resolve these or check what is happening ?

Please ignore, this issue is fixed. Merge the latest from main.

Copy link
Contributor

@NeethuES-intel NeethuES-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need intel-retail/documentation#57 merged in before this PR can go in. Please work on the latest review comments in intel-retail/documentation#57

@francis-tanyx
Copy link
Author

@NeethuES-intel

added modifications based on PR: #684

@NeethuES-intel
Copy link
Contributor

@NeethuES-intel

added modifications based on PR: #684

@francis-tanyx can you update the branch ?

@francis-tanyx
Copy link
Author

@NeethuES-intel

Okay update performed. Will check on the other PR to see if the Readme.md are modified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: move documentation from individual services to a new section under Automated Self Checkout in doc repo
2 participants