Fix test_elastic_training_agent.py for torch version 2.4 and above. #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengchenyu
requested review from
workingloong,
samplise,
BalaBalaYi and
majieyue
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are two changes:
(1) After pytorch/pytorch@67d3e4f, the parametes
redirectsandteeare removed. Although #1130 solved this problem, it seems that the unit test part has not been modified.(2) The unit test will be stuck. #1279 make compatibility in torch-2.4. But after this, for the unit test, we have to wait for all workers to finish writing data to
torchelastic/role_info/{i}. But the unit test does not mock this. so will stuck util timeout.In fact, we don’t need to process the data as pytorch/pytorch@dc4c75b because we already have the rank list.
Why are the changes needed?
Fix test_elastic_training_agent.py for torch version 2.4 and above.
Does this PR introduce any user-facing change?
No
How was this patch tested?
test in pytorch-2.6, pytorch-2.3, pytorch-2.2