-
Notifications
You must be signed in to change notification settings - Fork 22
[monitorlib/rid injection] Enforce and fix UAS ID at TestFlight level #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remark: It will also mean mock_uss will clean those field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if the TestFlight
is invalid with this change the constructor will start raising ValueError
. That sounds reasonable in isolation however is this caught and handled correctly in callers?
When injecting a flight or getting data from an injected flight that sounds reasonable since that would be a configuration error.
However within the mock USS, or potentially other callers, this may not be appropriate. E.g. in mock USS for such an issue I would expect the mock USS to catch the exception and return an HTTP bad param response.
Have you checked those things?
Other than that the change LGTM.
Co-authored-by: Mickaël Misbach <[email protected]>
Seems mock USS handle it already and return the response: TestFlight doesn't seems to be used in others situation, so I do assume we're fine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking 👍
…#1006) Co-authored-by: Mickaël Misbach <[email protected]> 1406c48
…#1006) Co-authored-by: Mickaël Misbach <[email protected]> 1406c48
…#1006) Co-authored-by: Mickaël Misbach <[email protected]> 1406c48
This PR partially addresses #1003 by fixing the UAS ID Field duplication in the
TestFlight
class, meaning it will be fixed when injecting a flight and when getting data from an injected flight.A small typo has been fixed in checks, and a side small fix of
filter_invalid_telemetry
passed to the parent class has been done.