fix: safari renders images correctly #753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: safari renders images correctly
Description
Safari was doing something weird with the response coming from verified-fetch, simply by constructing a new response object with the same body, status, statusText, and headers was enough to fix the issue.
Related: #751
Related: https://github.com/SgtPooki/safari-sw-image-bug-repro
Notes & open questions
When comparing the responses with the following function:
The only observed differences were:
type
default
basic
url
http://127.0.0.1:3000/ipfs/bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi
Change checklist