fix: include append logic in no_null_override transformer #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Would you mind rebasing to get the failing test workflow to pass? |
tbalzer
force-pushed
the
fix-append-no-null-override
branch
from
c8fc1fe to
0a9fe1a
Compare
Sure, done. |
Signed-off-by: Tim Balzer <[email protected]>
tbalzer
force-pushed
the
fix-append-no-null-override
branch
from
0a9fe1a to
42c18ef
Compare
isometry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #83 by adding logic to the
noNullOverrideTransformerto handle theappendlogic along with a unit test for this.