Solved Issues: #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1raghavmahajan
commented
Jun 6, 2017
1raghavmahajan
commented
- The API didn't actually take the picture after asking for permission unless clicked again.
- Added support for custom file names while implementing the listener.
- Added support for inline listeners as opposed to Activity/Fragment implementation.
- Added support for higher API Fragment.
- Updated Build.Gradle files.
- The API didn't actually take the picture after asking for permission unless clicked again. - Added support for custom file names while implementing the listener. - Added support for inline listeners as opposed to Activity/Fragment implementation. - Added support for higher API Fragment.
1raghavmahajan
commented
Jun 6, 2017
| @@ -3,6 +3,8 @@ | |||
| <component name="ProjectModuleManager"> | |||
| <modules> | |||
| <module fileurl="file://$PROJECT_DIR$/ImageAttachment.iml" filepath="$PROJECT_DIR$/ImageAttachment.iml" /> | |||
| <module fileurl="file://$PROJECT_DIR$/ImageAttachment.iml" filepath="$PROJECT_DIR$/ImageAttachment.iml" /> | |||
There was a problem hiding this comment.
Redundant: Can be removed
1raghavmahajan
commented
Jun 6, 2017
| @@ -3,6 +3,8 @@ | |||
| <component name="ProjectModuleManager"> | |||
| <modules> | |||
| <module fileurl="file://$PROJECT_DIR$/ImageAttachment.iml" filepath="$PROJECT_DIR$/ImageAttachment.iml" /> | |||
| <module fileurl="file://$PROJECT_DIR$/ImageAttachment.iml" filepath="$PROJECT_DIR$/ImageAttachment.iml" /> | |||
| <module fileurl="file://$PROJECT_DIR$/app/app.iml" filepath="$PROJECT_DIR$/app/app.iml" /> | |||
There was a problem hiding this comment.
Redundant: Can be removed
1raghavmahajan
commented
Jun 6, 2017
|
|
||
| this.context = act; | ||
| this.current_activity = act; | ||
| imageAttachment_callBack = (ImageAttachmentListener) fragment; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.