Skip to content

Experimental Style funcs for progress #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2025
Merged

Conversation

ptxmac
Copy link
Contributor

@ptxmac ptxmac commented Jul 12, 2025

This is an idea for extending the progress package with fully custom rendering functions.

In this PR it's only implemented for a single part of the rendering, just enough to illustrate the idea.

Or with a 24 bit color terminal, you could do something like this:

@coveralls
Copy link

coveralls commented Jul 12, 2025

Pull Request Test Coverage Report for Build 16539408798

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.823%

Totals Coverage Status
Change from base Build 16513072521: 0.0%
Covered Lines: 3958
Relevant Lines: 3965

💛 - Coveralls

@jedib0t
Copy link
Owner

jedib0t commented Jul 25, 2025

Looks really cool. Unfortunately I merged another PR before yours, leading to merge conflicts. Hold on for a few days, till I take a look. Thanks.

@ptxmac
Copy link
Contributor Author

ptxmac commented Jul 25, 2025

I'v erebased on main

Copy link
Owner

@jedib0t jedib0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate the contribution and the effort here. Can you please take a look at the comments?

Copy link

@jedib0t jedib0t merged commit 2ac3ff0 into jedib0t:main Jul 28, 2025
4 checks passed
@jedib0t
Copy link
Owner

jedib0t commented Jul 28, 2025

Thanks for the contribution! 👍🏽

@jedib0t
Copy link
Owner

jedib0t commented Jul 28, 2025

Your code is now available in tag https://github.com/jedib0t/go-pretty/releases/tag/v6.6.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants