Remove forbidden properties #204
Conversation
fixes jeremy-compostella#200 remove undo from message-sent-hook as it was causing an error and for html drafts to be sent after successful message sending (unintended behavior). Also discussed in jeremy-compostella#182 where the hook was suspected to be causing problems jeremy-compostella#182 Note, in jeremy-compostella#182 multiple users report no issues after removing hook. As requested, only turn remove hook from mu4e
This matches the behavior of message-mode
|
Hello, I am currently investigating this issue as well and while I applied your patch, the draft is still present after the message is sent. On your side, has the draft disappeared or it is still present? |
|
@seblemaguer I also re-installed org-msg from @spencerjackson 's branch. The previous error ( (The config context is doom-emacs) |
|
@gambhiro ok thanks. I will try to see if I can find what is going on there :) |
|
Starting my investigation, I am confused with these two lines (links being https://github.com/jeremy-compostella/org-msg/blob/59e2042e5f23e25f31c6aef0db1e70c6f54f117d/org-msg.el#L1506C16-L1508C15 ): (when-let ((sent-hook (org-msg--mu4e-fun "compose-before-send")))
(add-hook 'message-sent-hook sent-hook nil t)))why do we had the "before-send" to the "sent" hook? If I comment these, this solves the issue of the draft being not remove, but I want to be sure that I don't miss anything. |
|
Hi! The problem persists... Any updates on that? Thanks a lot! 😇 |
This change (motivated by the investigation here, adopts infrastructure from message-mode to strip the read-only property from any text inserted into an org-msg compose buffer.
This matches the behavior of mu4e's buffer, and prevents an issue where mu4e adds read-only text which message-send can't correctly process.