Test e2e #364
Draft
Test e2e #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcollom
reviewed
Apr 29, 2025
klone.yaml
Outdated
There was a problem hiding this comment.
i'm not a huge fan of the make file modules etc... I'd rather see things like kind clusters etc being provisioned within the testing suite/framework rather than a lot of make targets, that way the number of tools needed to run is far simpler and easier to achieve for new comers to the project.
davidcollom
reviewed
Apr 29, 2025
Comment on lines
240
to
+241
| req.Header.Set("Accept", header) | ||
| req.Header.Add("Accept", ociV1Header) |
There was a problem hiding this comment.
Should this be a comma-separated list? https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.1
Suggested change
| req.Header.Set("Accept", header) | |
| req.Header.Add("Accept", ociV1Header) | |
| req.Header.Set("Accept", strings.Join(",", []string{header,ociV1Header}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.