Skip to content

Improve contrast of foreground #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Shitanshukumar607
Copy link

@Shitanshukumar607 Shitanshukumar607 commented Jun 29, 2025

Closes #67

Darkened foreground to #bebebe for better visibility in dark mode.

Summary by CodeRabbit

  • Style
    • Updated the foreground color in the "notebook" theme's dark mode for improved appearance.

Copy link

vercel bot commented Jun 29, 2025

@Shitanshukumar607 is attempting to deploy a commit to the tweakcn OSS program Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

coderabbitai bot commented Jun 29, 2025

Walkthrough

The change updates the "foreground" color value in the "notebook" theme preset's dark mode from "#dcdcdc" to "#bebebe" within the theme presets utility file. No other modifications or additions were made to the codebase.

Changes

File(s) Change Summary
utils/theme-presets.ts Updated "notebook" dark style "foreground" color value from "#dcdcdc" to "#bebebe".

Assessment against linked issues

Objective Addressed Explanation
Fix Outline Badge display in Dark mode with Neutral Book theme (#67)

Poem

In the land of code where colors gleam,
The notebook theme found a subtle dream.
Foreground hue now soft and bright,
Outline Badges shine just right.
With every shade, a bug undone—
Rabbits cheer, the fix is won!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

utils/theme-presets.ts

Oops! Something went wrong! :(

ESLint: 9.24.0

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in " » eslint-config-next/core-web-vitals » /node_modules/.pnpm/[email protected][email protected][email protected][email protected]/node_modules/eslint-config-next/index.js".

If you still can't figure out the problem, please see https://eslint.org/docs/latest/use/troubleshooting.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11d071d and ad18e48.

📒 Files selected for processing (1)
  • utils/theme-presets.ts (1 hunks)
🔇 Additional comments (1)
utils/theme-presets.ts (1)

657-659: Contrast ratio sufficient (7.62:1 > 4.5:1)
The background #2b2b2b against the foreground #bebebe yields a 7.62:1 contrast ratio, comfortably above the WCAG AA requirement for normal text. No adjustments needed here.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Shitanshukumar607
Copy link
Author

Hey! Just checking if the PR looks good or if you'd like me to change anything.

@jnsahaj
Copy link
Owner

jnsahaj commented Jul 1, 2025

Hi @Shitanshukumar607, in my opinion the actual fix would involve modifying the tokens of the Badge being used.
The current issue is present for many themes, not just for Notebook

@Shitanshukumar607
Copy link
Author

Sorry I didn't understand the token of the badges. Could me please tell me more about them? Thanks.

@jnsahaj
Copy link
Owner

jnsahaj commented Jul 3, 2025

I mean that this issue is also present for other themes. So instead of updating the theme colors, we should really fix the element's colors that it uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Dark mode with the Neutral Book theme, the Outline Badge does not display correctly when hovering over the MailList button.
2 participants