-
-
Notifications
You must be signed in to change notification settings - Fork 365
Improve contrast of foreground #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Shitanshukumar607 is attempting to deploy a commit to the tweakcn OSS program Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe change updates the "foreground" color value in the "notebook" theme preset's dark mode from "#dcdcdc" to "#bebebe" within the theme presets utility file. No other modifications or additions were made to the codebase. Changes
Assessment against linked issues
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
utils/theme-presets.tsOops! Something went wrong! :( ESLint: 9.24.0 ESLint couldn't find the plugin "eslint-plugin-react-hooks". (The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-react-hooks" was referenced from the config file in " » eslint-config-next/core-web-vitals » /node_modules/.pnpm/[email protected][email protected][email protected][email protected]/node_modules/eslint-config-next/index.js". If you still can't figure out the problem, please see https://eslint.org/docs/latest/use/troubleshooting. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Hey! Just checking if the PR looks good or if you'd like me to change anything. |
Hi @Shitanshukumar607, in my opinion the actual fix would involve modifying the tokens of the Badge being used. |
Sorry I didn't understand the token of the badges. Could me please tell me more about them? Thanks. |
I mean that this issue is also present for other themes. So instead of updating the theme colors, we should really fix the element's colors that it uses. |
Closes #67
Darkened foreground to #bebebe for better visibility in dark mode.
Summary by CodeRabbit