Fixed Makie error in interactive_orbitdiagram
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the
Makie.Layout
error I raised in JuliaDynamics#237 by removing that qualifier from thedeactivate_interaction!
call.Other changes that can be ommitted upon review
display(figure)
calls because they seemed unnecessary and aren't shared by the other interactive plotting scripts.Vector{Point2f}
in the firstminimal_normalized_od
method because the length is known at compile time (the other method has conditional push so left it as is)Test.jl
based CI for a reason or was just never implemented. The test fails with an error with the prior code but passes now.