Skip to content

Fixed Makie error in interactive_orbitdiagram #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

jonathanfischer97
Copy link
Owner

I fixed the Makie.Layout error I raised in JuliaDynamics#237 by removing that qualifier from the deactivate_interaction! call.

Other changes that can be ommitted upon review

  • I removed some display(figure) calls because they seemed unnecessary and aren't shared by the other interactive plotting scripts.
  • I preallocated the Vector{Point2f} in the first minimal_normalized_od method because the length is known at compile time (the other method has conditional push so left it as is)
  • Finally, I added a testset and a test for calling this plotting function. Not sure if you guys don't use a Test.jl based CI for a reason or was just never implemented. The test fails with an error with the prior code but passes now.

@jonathanfischer97 jonathanfischer97 merged commit 921c7a2 into main May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant