This repository was archived by the owner on Nov 30, 2020. It is now read-only.
Add control deduction functions #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 22, 2020 21:42
And in to dedicated file.
In preparation for adding more functionality. I don't want the index file to be cluttered.
I wouldn't want to clear the cache unless I also wanted to run the tests, right?
This one has definitely proved that we should be providing helper functions rather than just ordered constants. It's not really a constant that ORDERED_POZITIONS variable. But I've stuck with the pattern defined elsewhere before I have a review in a moment.
We can rely on the Map to be ordered so this will do as our function for getting ordered ids.
The order of the arrays returned will soon be critical so make higher demands in tests of this function.
No longer required now we have the getOrderedPitchIds function.
No longer required since pozitionMap is already ordered and offers improved functionality.
added 9 commits
May 24, 2020 19:17
added 8 commits
May 24, 2020 22:05
js-jslog
commented
May 25, 2020
added 9 commits
May 25, 2020 18:55
The CovariantControlVars type which is described at the end does not actually exist yet, but it will soon. It will replace GenericControlVars.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 dependent control items:
Given 2 of these we should be able to determine the third. This is important for using the control system in the UI since we will want to lock one variable, alter a second and see the third vary in line.