fix: linting #95

levino · 2024-05-23T06:44:29Z

still working on this

vercel · 2024-05-23T06:44:32Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jsonresume-org-homepage2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 23, 2024 7:34am
jsonresume-org-registry	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 23, 2024 7:34am

changeset-bot · 2024-05-23T06:44:32Z

⚠️ No Changeset found

Latest commit: 985ad9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2024-05-23T06:44:33Z

Walkthrough

The recent updates primarily focus on standardizing ESLint configurations across various projects. The apps/homepage2 project saw simplification by removing specific settings and extending a custom configuration, while three packages (jsonresume-theme-cv, jsonresume-theme-standard, and jsonresume-theme-tailwind) introduced new ESLint configurations tailored for React. These changes aim to streamline linting rules and ensure consistency across different codebases.

Changes

File Path	Change Summary
`apps/homepage2/.eslintrc.js`	Simplified configuration by removing `parser`, `parserOptions`, `plugins`, and `settings`; added `env` section; extended `'custom'`.
`packages/jsonresume-theme-.../.eslintrc`	Introduced new ESLint configurations extending custom settings for React.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ef3d7c6 and 985ad9a.

Files ignored due to path filters (16)

apps/homepage2/package.json is excluded by !**/*.json
apps/registry/package.json is excluded by !**/*.json
package.json is excluded by !**/*.json
packages/eslint-config-custom/package.json is excluded by !**/*.json
packages/jsonresume-theme-cv/package.json is excluded by !**/*.json
packages/jsonresume-theme-flat/package.json is excluded by !**/*.json
packages/jsonresume-theme-full/package.json is excluded by !**/*.json
packages/jsonresume-theme-onepage/package.json is excluded by !**/*.json
packages/jsonresume-theme-spartacus/package.json is excluded by !**/*.json
packages/jsonresume-theme-standard/package.json is excluded by !**/*.json
packages/jsonresume-theme-tailwind/package.json is excluded by !**/*.json
packages/tsconfig/package.json is excluded by !**/*.json
packages/ui/package.json is excluded by !**/*.json
pnpm-lock.yaml is excluded by !pnpm-lock.yaml, !**/*.yaml
themes/papirus/package.json is excluded by !**/*.json
themes/stackoverflow/package.json is excluded by !**/*.json

Files selected for processing (4)

apps/homepage2/.eslintrc.js (1 hunks)
packages/jsonresume-theme-cv/.eslintrc (1 hunks)
packages/jsonresume-theme-standard/.eslintrc (1 hunks)
packages/jsonresume-theme-tailwind/.eslintrc (1 hunks)

Files skipped from review due to trivial changes (4)

apps/homepage2/.eslintrc.js
packages/jsonresume-theme-cv/.eslintrc
packages/jsonresume-theme-standard/.eslintrc
packages/jsonresume-theme-tailwind/.eslintrc

levino

This should fix any issues we encountered.

Important lessons:

do not use eslint@9 or above (we can do it, but we also need to migrate all configs).
do not add eslint.config.js files because they enable the new "flat config" mode of eslint@8.

levino · 2024-05-23T07:32:23Z

apps/homepage2/.eslintrc.js

+  env: {
+    browser: true,
+    es2021: true,
+    jquery: true,


This enables the usage of $ in the code.

levino · 2024-05-23T07:32:59Z

apps/homepage2/package.json

@@ -52,13 +53,11 @@
    "uuid": "^9.0.0"
  },
  "devDependencies": {
-    "@babel/eslint-parser": "^7.24.5",


I am not sure that I removed all unnecessary dependencies. Where did you use this dependency?

can't remember +1 to remove

levino · 2024-05-23T07:33:21Z

packages/jsonresume-theme-flat/package.json

-    "@babel/eslint-parser": "^7.24.5",
-    "eslint": "^9.3.0",
-    "eslint-plugin-react": "^7.33.2"


I think in general, these are unnecessary. Removed them.

levino · 2024-05-23T07:34:04Z

packages/jsonresume-theme-flat/package.json

-  "license": "MIT",
-  "devDependencies": {
-    "@babel/eslint-parser": "^7.24.5",
-    "eslint": "^9.3.0",


Unfortunately this is quite dangerous. We use eslint@8. eslint@9 brings breaking changes with regards to the configuration and bringing it into the project will create all kinds of nightmares.

levino · 2024-05-23T07:35:43Z

eslint.config.js

@thomasdavis this was the main mistake, I think. Adding this file means "opting into the new flat config" for eslint. eslint will then ignore all .eslintrc files.

yeah great to know

thomasdavis

This is awesome, great work.

noted to not go to eslint9 (i'm in no rush)

vercel bot deployed to Preview – jsonresume-org-homepage2 May 23, 2024 06:45 View deployment

vercel bot deployed to Preview – jsonresume-org-registry May 23, 2024 06:47 View deployment

fix: linting

985ad9a

levino force-pushed the feature/fix-linting branch from af5aee9 to 985ad9a Compare May 23, 2024 07:32

levino marked this pull request as ready for review May 23, 2024 07:32

vercel bot deployed to Preview – jsonresume-org-registry May 23, 2024 07:33 View deployment

vercel bot deployed to Preview – jsonresume-org-homepage2 May 23, 2024 07:34 View deployment

coderabbitai bot reviewed May 23, 2024

View reviewed changes

levino commented May 23, 2024

View reviewed changes

thomasdavis approved these changes May 24, 2024

View reviewed changes

levino merged commit f60a1aa into master May 24, 2024
7 checks passed

levino deleted the feature/fix-linting branch May 24, 2024 12:47

fix: linting #95

fix: linting #95

Uh oh!

Conversation

levino commented May 23, 2024

Uh oh!

vercel bot commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

levino left a comment

Choose a reason for hiding this comment

Uh oh!

levino May 23, 2024

Choose a reason for hiding this comment

Uh oh!

levino May 23, 2024

Choose a reason for hiding this comment

Uh oh!

thomasdavis May 24, 2024

Choose a reason for hiding this comment

Uh oh!

levino May 23, 2024

Choose a reason for hiding this comment

Uh oh!

levino May 23, 2024

Choose a reason for hiding this comment

Uh oh!

levino May 23, 2024

Choose a reason for hiding this comment

Uh oh!

thomasdavis May 24, 2024

Choose a reason for hiding this comment

Uh oh!

thomasdavis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vercel bot commented May 23, 2024 •

edited

Loading

changeset-bot bot commented May 23, 2024 •

edited

Loading

coderabbitai bot commented May 23, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)