Skip to content

Added Source converted to Package #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Selva1910
Copy link

@Selva1910 Selva1910 commented Jul 12, 2025

Description

Converted the Unity Source into Package. So that, it can be added from git directly. And Added Overridable folder for builds. Right now for WebGL. Also, Refactored the Addressable uncomment approach with Symbols.

Can you check this @juicycleff

Type of Change

@timbotimbo
Copy link
Collaborator

timbotimbo commented Jul 22, 2025

Hey, I think you've made some useful contributions here but it is really hard to view the changes.

Because you made your changes in a copy of the original files, everything in this PR just shows up as a new file.
But when I check the individual files, a lot seems to have actually changed inside them.

For example, I just pasted build.cs into an online diff tool and I see hundreds of changed lines.
From a quick look of build.cs:

  • Added customized export paths + GUI
  • Added addressables define logic
  • Code formatting changes
  • Removed il2cpp compiler setting for Unity 2022 but added it for 6000.
    It also ignores the debug/release option for 6000.
  • Added spaces in css identifiers which likely breaks the actual css.
    #unity-container -> # unity-container

Your package and the Unity example now also contain different versions of the export scripts.

Could you somehow split these changes?

Maybe:

  • Apply code changes in the Unity example and move that to unity_package.
  • Or move the code from the Unity excample first and then apply your changes.

Afterwards you could probably import the package in the Unity example to avoid duplicating these scripts in the repo.

The unity 6000 branch also includes (minor) export changes to handle breaking changes in Unity 6.

It might be good if I ported those over to master before applying a major change like this.

Juicycleff isn't very active anymore, so this repo and the pub.dev plugin are nearly abandoned.
I try to do some minimal maintenance to keep it running, but I have limited permissions to the master branch.
So I can't quickly modify small issues possibly introduced by a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants