-
Notifications
You must be signed in to change notification settings - Fork 937
Allow configuring karmada-apiserver OIDC via Helm #6159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @tw-mnewman! It looks like this is your first PR to karmada-io/karmada 🎉 |
d3fef38
to
d6492f7
Compare
karmada-io#6144 Signed-off-by: Matt Newman <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6159 +/- ##
==========================================
+ Coverage 48.07% 48.08% +0.01%
==========================================
Files 668 668
Lines 55327 55327
==========================================
+ Hits 26597 26603 +6
+ Misses 26992 26987 -5
+ Partials 1738 1737 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looks good to me, thank you @tw-mnewman for doing this!
@a7i Long time no see, hope you are doing well~ Would you like to take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏆
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7i The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Initial implementation of #6144, for Helm only.
Special notes for your reviewer:
Other installation methods can be handled in separate PRs, if that's OK.
Does this PR introduce a user-facing change?: