Skip to content

Allow configuring karmada-apiserver OIDC via Helm #6159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

tw-mnewman
Copy link
Contributor

@tw-mnewman tw-mnewman commented Feb 24, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Initial implementation of #6144, for Helm only.

Special notes for your reviewer:

Other installation methods can be handled in separate PRs, if that's OK.

Does this PR introduce a user-facing change?:

`HELM Chart`: OpenID Connect based auth can be configured for the Karmada API server when installing via Helm

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 24, 2025
@karmada-bot karmada-bot requested review from a7i and jrkeen February 24, 2025 19:56
@karmada-bot
Copy link
Collaborator

Welcome @tw-mnewman! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2025
@tw-mnewman tw-mnewman force-pushed the 6144 branch 2 times, most recently from d3fef38 to d6492f7 Compare February 24, 2025 20:00
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.08%. Comparing base (006cf70) to head (98aa22c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6159      +/-   ##
==========================================
+ Coverage   48.07%   48.08%   +0.01%     
==========================================
  Files         668      668              
  Lines       55327    55327              
==========================================
+ Hits        26597    26603       +6     
+ Misses      26992    26987       -5     
+ Partials     1738     1737       -1     
Flag Coverage Δ
unittests 48.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Looks good to me, thank you @tw-mnewman for doing this!

@a7i Long time no see, hope you are doing well~ Would you like to take a look?

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
Copy link
Contributor

@a7i a7i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2025
@karmada-bot karmada-bot merged commit 3b6c0e0 into karmada-io:master Feb 28, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants