Skip to content

fix: accentuated characters encoded values causes error if in history #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: accentuated characters encoded values causes error if in history #1004

wants to merge 2 commits into from

Conversation

SamuelVanie
Copy link

  • Add a utility function to convert values into utf8 characters before adding them to history (buffer)
  • Make sure these characters are converted before passing them as data to curl

@SamuelVanie
fix: french characters encoded values causes error if in history
491630b 
- Add a utility function to convert values into utf8 characters before adding
them to history (buffer)
- Make sure there are converted before passing them as data to curl
@SamuelVanie
Copy link
Author

SamuelVanie commented Aug 5, 2025 •
edited
Loading

I've made a fix for the issue #1001 that I've identified. Now having characters with accent in tool call results or anywhere in the history doesn't causes error even with gptel-include-tool-results set to t.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SamuelVanie