-
Notifications
You must be signed in to change notification settings - Fork 19.6k
update python version #21517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update python version #21517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @divyashreepathihalli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the project's Python version from 3.10 to 3.11. This change is necessary to support the installation of Flax, a dependency that requires this newer Python version. My modifications span across development environment configurations, continuous integration scripts, project metadata, and user-facing documentation to ensure a consistent and functional setup with Python 3.11.
Highlights
- Development Container Update: I've updated the Python version used in the development container from 3.10 to 3.11, ensuring that the development environment aligns with the new requirements.
- CI/CD Build Script Adjustment: I've modified the Kokoro build script to explicitly use Python 3.11 for GPU builds, ensuring that continuous integration processes reflect the updated Python version.
- Documentation Updates: I've updated both the
CONTRIBUTING.md
andREADME.md
files to reflect the new minimum Python version requirement of 3.11, providing clear guidance for contributors and users. - Project Configuration Update: I've adjusted the
pyproject.toml
file to declare Python 3.11 as the minimum required version and updated the programming language classifiers accordingly.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the required Python version from 3.10 to 3.11 across various project files, including configuration, documentation, and build scripts. The changes appear to be consistent with the goal of upgrading the Python version. I have one suggestion for improvement in pyproject.toml
to remove a duplicated classifier entry.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21517 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 567 567
Lines 56222 56222
Branches 8787 8787
=======================================
Hits 46505 46505
Misses 7560 7560
Partials 2157 2157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
to support flax installation