Hover links for Errors #700
Open
+802
−286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link to type add more errors update Get links working work on refactoring error logic to include short messages gate based on flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow linking to names and types in error messages on hover. Starts addressing #699.
I've updated just a few error messages to include the link information, but wanted to get feedback and this merged before updating other error messages. The links to names are highlighted in blue below. I can keep the original color of identifiers and types or make them blue. I haven't seen if I can do underlining.
Errors are now identified by a code and short description associated with that code stating the problem.
Longer descriptions include location-specific information about the specific issue, as well as hints for how to solve it.
I also think that the "context" information is not necessary for errors in VSCode since the range is already underlined in red. I have not removed that yet, awaiting some discussion.