Skip to content

Process downloaded data #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2020
Merged

Process downloaded data #5

merged 2 commits into from
Apr 6, 2020

Conversation

tmiskow
Copy link
Collaborator

@tmiskow tmiskow commented Apr 6, 2020

  • filter transcript jsons and save results as one csv file
  • generate wav audio clips for every sentence in the transcript
  • todo: add generated files to dvc

Unfortunately, the phonemizer library downloads NLTK dependencies during the import phase, making it very difficult to properly configure. I managed a workaround, but I looks kinda ugly. Looking forward to seeing some feedback on that.

Issue: Kyubyong/g2p#12

@tmiskow tmiskow requested a review from kowaalczyk April 6, 2020 17:45
kowaalczyk
kowaalczyk approved these changes Apr 6, 2020
View reviewed changes
Copy link
Owner

@kowaalczyk kowaalczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - I will test it later in my vocoder branch since it will surely require some changes to audio processing.

@tmiskow tmiskow merged commit 9fe5baa into master Apr 6, 2020
@kowaalczyk kowaalczyk deleted the process-downloaded-data branch April 8, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kowaalczyk kowaalczyk kowaalczyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmiskow @kowaalczyk