Skip to content

move ASOAPI out of experimental #4969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024
Merged

move ASOAPI out of experimental #4969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 .../v1alpha1/azureasomanagedcluster_types.go → api/v1alpha1/azureasomanagedcluster_types.go
View file
Open in desktop
File renamed without changes.
0 ...1alpha1/azureasomanagedcluster_webhook.go → ...1alpha1/azureasomanagedcluster_webhook.go
View file
Open in desktop
File renamed without changes.
0 ...1/azureasomanagedclustertemplate_types.go → ...1/azureasomanagedclustertemplate_types.go
View file
Open in desktop
File renamed without changes.
0 ...pha1/azureasomanagedcontrolplane_types.go → ...pha1/azureasomanagedcontrolplane_types.go
View file
Open in desktop
File renamed without changes.
0 ...a1/azureasomanagedcontrolplane_webhook.go → ...a1/azureasomanagedcontrolplane_webhook.go
View file
Open in desktop
File renamed without changes.
0 ...reasomanagedcontrolplanetemplate_types.go → ...reasomanagedcontrolplanetemplate_types.go
View file
Open in desktop
File renamed without changes.
0 ...lpha1/azureasomanagedmachinepool_types.go → ...lpha1/azureasomanagedmachinepool_types.go
View file
Open in desktop
File renamed without changes.
0 ...ha1/azureasomanagedmachinepool_webhook.go → ...ha1/azureasomanagedmachinepool_webhook.go
View file
Open in desktop
File renamed without changes.
0 ...ureasomanagedmachinepooltemplate_types.go → ...ureasomanagedmachinepooltemplate_types.go
View file
Open in desktop
File renamed without changes.
0 exp/api/v1alpha1/doc.go → api/v1alpha1/doc.go
View file
Open in desktop
File renamed without changes.
0 exp/api/v1alpha1/groupversion_info.go → api/v1alpha1/groupversion_info.go
View file
Open in desktop
File renamed without changes.
0 exp/api/v1alpha1/zz_generated.deepcopy.go → api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop
File renamed without changes.
116 changes: 58 additions & 58 deletions config/webhook/manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,20 +211,18 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azurecluster
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally, git tells me the diff here is just that some of the webhooks got reordered with no other changes:

diff --git a/config/webhook/manifests.yaml b/config/webhook/manifests.yaml
index ef0911274..de5ab8e64 100644
--- a/config/webhook/manifests.yaml
+++ b/config/webhook/manifests.yaml
@@ -204,6 +204,66 @@ kind: ValidatingWebhookConfiguration
 metadata:
   name: validating-webhook-configuration
 webhooks:
+- admissionReviewVersions:
+  - v1
+  - v1beta1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedcluster
+  failurePolicy: Fail
+  name: validation.azureasomanagedcluster.infrastructure.cluster.x-k8s.io
+  rules:
+  - apiGroups:
+    - infrastructure.cluster.x-k8s.io
+    apiVersions:
+    - v1alpha1
+    operations:
+    - CREATE
+    resources:
+    - azureasomanagedclusters
+  sideEffects: None
+- admissionReviewVersions:
+  - v1
+  - v1beta1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedcontrolplane
+  failurePolicy: Fail
+  name: validation.azureasomanagedcontrolplane.infrastructure.cluster.x-k8s.io
+  rules:
+  - apiGroups:
+    - infrastructure.cluster.x-k8s.io
+    apiVersions:
+    - v1alpha1
+    operations:
+    - CREATE
+    resources:
+    - azureasomanagedcontrolplanes
+  sideEffects: None
+- admissionReviewVersions:
+  - v1
+  - v1beta1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedmachinepool
+  failurePolicy: Fail
+  name: validation.azureasomanagedmachinepool.infrastructure.cluster.x-k8s.io
+  rules:
+  - apiGroups:
+    - infrastructure.cluster.x-k8s.io
+    apiVersions:
+    - v1alpha1
+    operations:
+    - CREATE
+    resources:
+    - azureasomanagedmachinepools
+  sideEffects: None
 - admissionReviewVersions:
   - v1
   - v1beta1
@@ -442,66 +502,6 @@ webhooks:
     resources:
     - azuremanagedmachinepooltemplates
   sideEffects: None
-- admissionReviewVersions:
-  - v1
-  - v1beta1
-  clientConfig:
-    service:
-      name: webhook-service
-      namespace: system
-      path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedcluster
-  failurePolicy: Fail
-  name: validation.azureasomanagedcluster.infrastructure.cluster.x-k8s.io
-  rules:
-  - apiGroups:
-    - infrastructure.cluster.x-k8s.io
-    apiVersions:
-    - v1alpha1
-    operations:
-    - CREATE
-    resources:
-    - azureasomanagedclusters
-  sideEffects: None
-- admissionReviewVersions:
-  - v1
-  - v1beta1
-  clientConfig:
-    service:
-      name: webhook-service
-      namespace: system
-      path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedcontrolplane
-  failurePolicy: Fail
-  name: validation.azureasomanagedcontrolplane.infrastructure.cluster.x-k8s.io
-  rules:
-  - apiGroups:
-    - infrastructure.cluster.x-k8s.io
-    apiVersions:
-    - v1alpha1
-    operations:
-    - CREATE
-    resources:
-    - azureasomanagedcontrolplanes
-  sideEffects: None
-- admissionReviewVersions:
-  - v1
-  - v1beta1
-  clientConfig:
-    service:
-      name: webhook-service
-      namespace: system
-      path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedmachinepool
-  failurePolicy: Fail
-  name: validation.azureasomanagedmachinepool.infrastructure.cluster.x-k8s.io
-  rules:
-  - apiGroups:
-    - infrastructure.cluster.x-k8s.io
-    apiVersions:
-    - v1alpha1
-    operations:
-    - CREATE
-    resources:
-    - azureasomanagedmachinepools
-  sideEffects: None
 - admissionReviewVersions:
   - v1
   - v1beta1

path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedcluster
failurePolicy: Fail
matchPolicy: Equivalent
name: validation.azurecluster.infrastructure.cluster.x-k8s.io
name: validation.azureasomanagedcluster.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
apiVersions:
- v1beta1
- v1alpha1
operations:
- CREATE
- UPDATE
resources:
- azureclusters
- azureasomanagedclusters
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -233,20 +231,18 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azureclusteridentity
path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedcontrolplane
failurePolicy: Fail
matchPolicy: Equivalent
name: validation.azureclusteridentity.infrastructure.cluster.x-k8s.io
name: validation.azureasomanagedcontrolplane.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
apiVersions:
- v1beta1
- v1alpha1
operations:
- CREATE
- UPDATE
resources:
- azureclusteridentities
- azureasomanagedcontrolplanes
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -255,20 +251,18 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azureclustertemplate
path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedmachinepool
failurePolicy: Fail
matchPolicy: Equivalent
name: validation.azureclustertemplate.infrastructure.cluster.x-k8s.io
name: validation.azureasomanagedmachinepool.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
apiVersions:
- v1beta1
- v1alpha1
operations:
- CREATE
- UPDATE
resources:
- azureclustertemplates
- azureasomanagedmachinepools
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -277,10 +271,10 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremachine
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azurecluster
failurePolicy: Fail
matchPolicy: Equivalent
name: validation.azuremachine.infrastructure.cluster.x-k8s.io
name: validation.azurecluster.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
Expand All @@ -290,7 +284,7 @@ webhooks:
- CREATE
- UPDATE
resources:
- azuremachines
- azureclusters
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -299,10 +293,10 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremachinetemplate
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azureclusteridentity
failurePolicy: Fail
matchPolicy: Equivalent
name: validation.azuremachinetemplate.infrastructure.cluster.x-k8s.io
name: validation.azureclusteridentity.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
Expand All @@ -312,7 +306,7 @@ webhooks:
- CREATE
- UPDATE
resources:
- azuremachinetemplates
- azureclusteridentities
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -321,9 +315,10 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremanagedcluster
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azureclustertemplate
failurePolicy: Fail
name: validation.azuremanagedclusters.infrastructure.cluster.x-k8s.io
matchPolicy: Equivalent
name: validation.azureclustertemplate.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
Expand All @@ -333,7 +328,7 @@ webhooks:
- CREATE
- UPDATE
resources:
- azuremanagedclusters
- azureclustertemplates
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -342,18 +337,20 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremanagedclustertemplate
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremachine
failurePolicy: Fail
name: validation.azuremanagedclustertemplates.infrastructure.cluster.x-k8s.io
matchPolicy: Equivalent
name: validation.azuremachine.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
apiVersions:
- v1beta1
operations:
- CREATE
- UPDATE
resources:
- azuremanagedclustertemplates
- azuremachines
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -362,9 +359,10 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremanagedcontrolplane
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremachinetemplate
failurePolicy: Fail
name: validation.azuremanagedcontrolplanes.infrastructure.cluster.x-k8s.io
matchPolicy: Equivalent
name: validation.azuremachinetemplate.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
Expand All @@ -374,7 +372,7 @@ webhooks:
- CREATE
- UPDATE
resources:
- azuremanagedcontrolplanes
- azuremachinetemplates
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -383,9 +381,9 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremanagedcontrolplanetemplate
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremanagedcluster
failurePolicy: Fail
name: validation.azuremanagedcontrolplanetemplates.infrastructure.cluster.x-k8s.io
name: validation.azuremanagedclusters.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
Expand All @@ -395,7 +393,7 @@ webhooks:
- CREATE
- UPDATE
resources:
- azuremanagedcontrolplanetemplates
- azuremanagedclusters
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -404,21 +402,18 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremanagedmachinepool
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremanagedclustertemplate
failurePolicy: Fail
matchPolicy: Equivalent
name: validation.azuremanagedmachinepools.infrastructure.cluster.x-k8s.io
name: validation.azuremanagedclustertemplates.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
apiVersions:
- v1beta1
operations:
- CREATE
- UPDATE
- DELETE
resources:
- azuremanagedmachinepools
- azuremanagedclustertemplates
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -427,9 +422,9 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremanagedmachinepooltemplate
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremanagedcontrolplane
failurePolicy: Fail
name: validation.azuremanagedmachinepooltemplates.infrastructure.cluster.x-k8s.io
name: validation.azuremanagedcontrolplanes.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
Expand All @@ -438,9 +433,8 @@ webhooks:
operations:
- CREATE
- UPDATE
- DELETE
resources:
- azuremanagedmachinepooltemplates
- azuremanagedcontrolplanes
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -449,18 +443,19 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedcluster
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremanagedcontrolplanetemplate
failurePolicy: Fail
name: validation.azureasomanagedcluster.infrastructure.cluster.x-k8s.io
name: validation.azuremanagedcontrolplanetemplates.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
apiVersions:
- v1alpha1
- v1beta1
operations:
- CREATE
- UPDATE
resources:
- azureasomanagedclusters
- azuremanagedcontrolplanetemplates
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -469,18 +464,21 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedcontrolplane
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremanagedmachinepool
failurePolicy: Fail
name: validation.azureasomanagedcontrolplane.infrastructure.cluster.x-k8s.io
matchPolicy: Equivalent
name: validation.azuremanagedmachinepools.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
apiVersions:
- v1alpha1
- v1beta1
operations:
- CREATE
- UPDATE
- DELETE
resources:
- azureasomanagedcontrolplanes
- azuremanagedmachinepools
sideEffects: None
- admissionReviewVersions:
- v1
Expand All @@ -489,18 +487,20 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedmachinepool
path: /validate-infrastructure-cluster-x-k8s-io-v1beta1-azuremanagedmachinepooltemplate
failurePolicy: Fail
name: validation.azureasomanagedmachinepool.infrastructure.cluster.x-k8s.io
name: validation.azuremanagedmachinepooltemplates.infrastructure.cluster.x-k8s.io
rules:
- apiGroups:
- infrastructure.cluster.x-k8s.io
apiVersions:
- v1alpha1
- v1beta1
operations:
- CREATE
- UPDATE
- DELETE
resources:
- azureasomanagedmachinepools
- azuremanagedmachinepooltemplates
sideEffects: None
- admissionReviewVersions:
- v1
Expand Down
Loading