Skip to content

bump ASO to v2.8.0 #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jul 9, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:

Bumps to ASO v2.8. Also removes some workarounds needed in older versions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4957

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

CAPZ now installs Azure Service Operator v2.8.0.
Go 1.22 is required to build CAPZ.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 9, 2024
@nojnhuh nojnhuh force-pushed the asotwodoteight branch 4 times, most recently from 250b3c2 to 8ed8517 Compare July 9, 2024 20:38
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.06%. Comparing base (9079793) to head (2236fa7).

Files Patch % Lines
main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4973       +/-   ##
===========================================
- Coverage   62.25%   51.06%   -11.19%     
===========================================
  Files         201      274       +73     
  Lines       16912    24643     +7731     
===========================================
+ Hits        10529    12585     +2056     
- Misses       5590    11256     +5666     
- Partials      793      802        +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 10, 2024

This should be ready for review.

/retitle bump ASO to v2.8.0

/release-note-edit

CAPZ now installs Azure Service Operator v2.8.0.
Go 1.22 is required to build CAPZ

@k8s-ci-robot k8s-ci-robot changed the title [WIP] bump ASO to v2.8.0 bump ASO to v2.8.0 Jul 10, 2024
@k8s-ci-robot k8s-ci-robot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 10, 2024
@mboersma mboersma added this to the v1.16 milestone Jul 10, 2024
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5e07231f8354e2c1c980d38221acaa12e29d93d1

@dtzar
Copy link
Contributor

dtzar commented Jul 11, 2024

LGTM, just needs to have merge conflicts resolved?

@mboersma mboersma added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mboersma July 11, 2024 23:35
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 11, 2024

/hold for squash

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2024
@nojnhuh nojnhuh removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 11, 2024

dependency review should be fixed by #4981

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 12, 2024
# Conflicts:
#	go.mod
#	go.sum
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 12, 2024

/retest

2 similar comments
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 12, 2024

/retest

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 12, 2024

/retest

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a36307856cacc523f4aabff80cb884ac2344bf42

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 12, 2024

/assign @jackfrancis

@jackfrancis
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@jackfrancis
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit e6159f8 into kubernetes-sigs:main Jul 12, 2024
22 checks passed
@nojnhuh nojnhuh deleted the asotwodoteight branch July 12, 2024 19:00
@jackfrancis jackfrancis mentioned this pull request Aug 6, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update ASO dep to 2.8.0
5 participants