-
Notifications
You must be signed in to change notification settings - Fork 456
bump ASO to v2.8.0 #4973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump ASO to v2.8.0 #4973
Conversation
250b3c2
to
8ed8517
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4973 +/- ##
===========================================
- Coverage 62.25% 51.06% -11.19%
===========================================
Files 201 274 +73
Lines 16912 24643 +7731
===========================================
+ Hits 10529 12585 +2056
- Misses 5590 11256 +5666
- Partials 793 802 +9 ☔ View full report in Codecov by Sentry. |
This should be ready for review. /retitle bump ASO to v2.8.0 /release-note-edit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 5e07231f8354e2c1c980d38221acaa12e29d93d1
|
LGTM, just needs to have merge conflicts resolved? |
# Conflicts: # go.mod
/hold for squash |
dependency review should be fixed by #4981 |
# Conflicts: # go.mod # go.sum
/retest |
2 similar comments
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: a36307856cacc523f4aabff80cb884ac2344bf42
|
/assign @jackfrancis |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Bumps to ASO v2.8. Also removes some workarounds needed in older versions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4957
Special notes for your reviewer:
TODOs:
Release note: