[Tilt] Drop SUBSCRIPTION_TYPE, do not peer vnets for all flavors and update vnet peering logic

[nawazkh]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

• This PR drops the need for setting SUBSCRIPTION_TYPE for 1P CAPZ users.
• Updates tilt logic to avoid setting the VNet peering for the default flavor as reported in Workload cluster creation/deletion with default flavor via Tilt fails on 1P subscription due to unexpected VNet peering #5586
• Updates VNet peering deletion logic to gracefully exit when no VNet Peerings are found.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5586

Special notes for your reviewer:

TODOs:

• squashed commits
• includes documentation
• adds unit tests
• cherry-pick candidate

Release note:

NONE

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.27%. Comparing base (14311b2) to head (beb7569).
Report is 9 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5587   +/-   ##
=======================================
  Coverage   53.27%   53.27%           
=======================================
  Files         272      272           
  Lines       29533    29533           
=======================================
  Hits        15735    15735           
  Misses      12983    12983           
  Partials      815      815           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[nawazkh]

We probably want to get this exported or updated so that 1P users can add their own flavors that need vnet peerings.
I will open up a good-first-issue to add this.

[nawazkh]

/label tide/merge-method-squash

[nawazkh]

/assign @willie-yao @alimaazamat

[k8s-ci-robot]

@nawazkh: GitHub didn't allow me to assign the following users: alimaazamat.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @willie-yao @alimaazamat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alimaazamat]

/lgtm works locally for me

[nawazkh]

@alimaazamat Thank you for checking this Alima! Just to confirm, did you also try clicking "delete-all-workload-clusters" tab ? Did that work as expected too ?

[alimaazamat]

@alimaazamat Thank you for checking this Alima! Just to confirm, did you also try clicking "delete-all-workload-clusters" tab ? Did that work as expected too ?

Yes works beautifully!

[willie-yao]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: eef44b235220e91149db7d5cd3afca1b491beecf

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [willie-yao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment