Skip to content

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Just using a branch to test out some ideas so I can give better feedback on #5517 -- please ignore!

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 30, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 30, 2025
@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-ci-entrypoint

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 22.58065% with 72 lines in your changes missing coverage. Please review.

Project coverage is 46.53%. Comparing base (d3c0f03) to head (4ff1f24).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
api/v1beta1/azureclustertemplate_webhook.go 10.00% 17 Missing and 1 partial ⚠️
api/v1beta1/azurecluster_webhook.go 20.00% 14 Missing and 2 partials ⚠️
exp/api/v1beta1/azuremachinepoolmachine_webhook.go 0.00% 10 Missing ⚠️
api/v1beta1/azureclusteridentity_webhook.go 30.76% 7 Missing and 2 partials ⚠️
api/v1beta1/azuremachinetemplate_webhook.go 61.53% 5 Missing ⚠️
api/v1beta1/azuremanagedclustertemplate_webhook.go 0.00% 5 Missing ⚠️
api/v1beta1/azuremanagedcluster_webhook.go 40.00% 3 Missing ⚠️
api/v1alpha1/azureasomanagedcluster_webhook.go 0.00% 2 Missing ⚠️
...pi/v1alpha1/azureasomanagedcontrolplane_webhook.go 0.00% 2 Missing ⚠️
api/v1alpha1/azureasomanagedmachinepool_webhook.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5600      +/-   ##
==========================================
- Coverage   53.28%   46.53%   -6.75%     
==========================================
  Files         272      272              
  Lines       29521    29574      +53     
==========================================
- Hits        15729    13762    -1967     
- Misses      12977    14999    +2022     
+ Partials      815      813       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-ci-entrypoint

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 30, 2025
@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-ci-entrypoint

@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Apr 30, 2025
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 30, 2025
@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-ci-entrypoint

1 similar comment
@mboersma
Copy link
Contributor Author

mboersma commented May 1, 2025

/test pull-cluster-api-provider-azure-ci-entrypoint

@mboersma
Copy link
Contributor Author

mboersma commented May 1, 2025

/test pull-cluster-api-provider-azure-e2e

@mboersma
Copy link
Contributor Author

mboersma commented May 1, 2025

/test pull-cluster-api-provider-azure-ci-entrypoint
/test pull-cluster-api-provider-azure-e2e

@mboersma
Copy link
Contributor Author

mboersma commented May 1, 2025

/test pull-cluster-api-provider-azure-build
/test pull-cluster-api-provider-azure-verify

@mboersma
Copy link
Contributor Author

mboersma commented May 1, 2025

/test pull-cluster-api-provider-azure-build
/test pull-cluster-api-provider-azure-ci-entrypoint
/test pull-cluster-api-provider-azure-e2e
/test pull-cluster-api-provider-azure-verify

@mboersma
Copy link
Contributor Author

mboersma commented May 2, 2025


Summarizing 2 Failures:
  [FAIL] Workload cluster creation Creating a VMSS cluster [REQUIRED] [It] with a single control plane node and an AzureMachinePool with 2 Linux and 2 Windows worker nodes
  /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/machinepool_helpers.go:91
  [FAIL] Workload cluster creation Creating a ipv6 control-plane cluster [REQUIRED] [It] With ipv6 worker node
  /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/machinepool_helpers.go:91

@mboersma
Copy link
Contributor Author

mboersma commented May 5, 2025

/test pull-cluster-api-provider-azure-build
/test pull-cluster-api-provider-azure-ci-entrypoint
/test pull-cluster-api-provider-azure-e2e
/test pull-cluster-api-provider-azure-verify

@mboersma
Copy link
Contributor Author

mboersma commented May 6, 2025

/test pull-cluster-api-provider-azure-e2e

tamalsaha and others added 14 commits May 7, 2025 12:18
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Co-authored-by: Matt Boersma <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
@mboersma
Copy link
Contributor Author

mboersma commented May 7, 2025

/test pull-cluster-api-provider-azure-e2e
/test pull-cluster-api-provider-azure-e2e-aks
/test pull-cluster-api-provider-azure-capi-e2e

@mboersma
Copy link
Contributor Author

mboersma commented May 7, 2025

/test pull-cluster-api-provider-azure-e2e

@k8s-ci-robot
Copy link
Contributor

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e 4ff1f24 link true /test pull-cluster-api-provider-azure-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2025
@mboersma
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning May 29, 2025
@mboersma mboersma deleted the k132-spike branch May 29, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants