Skip to content

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented May 6, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:


tamalsaha and others added 13 commits May 6, 2025 10:46
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Co-authored-by: Matt Boersma <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jackfrancis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 6, 2025
@nawazkh
Copy link
Member Author

nawazkh commented May 6, 2025

/close

@k8s-ci-robot
Copy link
Contributor

@nawazkh: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 21.73913% with 72 lines in your changes missing coverage. Please review.

Project coverage is 46.53%. Comparing base (86ea1f6) to head (dc84124).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/v1beta1/azureclustertemplate_webhook.go 10.00% 17 Missing and 1 partial ⚠️
api/v1beta1/azurecluster_webhook.go 20.00% 14 Missing and 2 partials ⚠️
exp/api/v1beta1/azuremachinepoolmachine_webhook.go 0.00% 10 Missing ⚠️
api/v1beta1/azureclusteridentity_webhook.go 30.76% 7 Missing and 2 partials ⚠️
api/v1beta1/azuremachinetemplate_webhook.go 61.53% 5 Missing ⚠️
api/v1beta1/azuremanagedclustertemplate_webhook.go 0.00% 5 Missing ⚠️
api/v1beta1/azuremanagedcluster_webhook.go 40.00% 3 Missing ⚠️
api/v1alpha1/azureasomanagedcluster_webhook.go 0.00% 2 Missing ⚠️
...pi/v1alpha1/azureasomanagedcontrolplane_webhook.go 0.00% 2 Missing ⚠️
api/v1alpha1/azureasomanagedmachinepool_webhook.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5618      +/-   ##
==========================================
- Coverage   53.28%   46.53%   -6.76%     
==========================================
  Files         272      272              
  Lines       29537    29574      +37     
==========================================
- Hits        15739    13762    -1977     
- Misses      12983    14999    +2016     
+ Partials      815      813       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nawazkh nawazkh deleted the nhk_k132 branch May 12, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants