-
Notifications
You must be signed in to change notification settings - Fork 456
Remove community AKS marketplace extension from e2e tests because no longer valid #5639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove community AKS marketplace extension from e2e tests because no longer valid #5639
Conversation
Hi @alimaazamat. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5639 +/- ##
=======================================
Coverage 53.27% 53.27%
=======================================
Files 272 272
Lines 29522 29522
=======================================
Hits 15729 15729
Misses 12978 12978
Partials 815 815 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/ok-to-test |
/lgtm |
LGTM label has been added. Git tree hash: c27469c2a7403c1eb896cf1fc46b97f4b26de518
|
/retest |
this lgtm, let's update |
5985092
to
411c655
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 8b0fb8b76934055c2c3240a26ec410407dc4ac39
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alimaazamat: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.19 |
@alimaazamat: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.18 |
@alimaazamat: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@alimaazamat: new pull request created: #5647 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@alimaazamat: new pull request created: #5648 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
AKS marketplace extension test failing because the TraefikLabs.TraefikProxy community extension no longer valid. Removed this AKS marketplace extension because we have an official aks extension in the tests already.
Failing Test: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-cluster-api-provider-azure-e2e-aks-main/1922878194831069184
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: