-
Notifications
You must be signed in to change notification settings - Fork 456
Use ipv6 template for ipv6 conformance instead of default template #5755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5755 +/- ##
=======================================
Coverage 52.81% 52.82%
=======================================
Files 279 279
Lines 29629 29629
=======================================
+ Hits 15650 15652 +2
+ Misses 13162 13160 -2
Partials 817 817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: bb4b030af25b3019017bca5322399a771a00cca9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.20 |
/cherry-pick release-1.19 |
@mboersma: new pull request created: #5760 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mboersma: #5755 failed to apply on top of branch "release-1.19":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The ipv6 conformance job has been effectively equivalent to the regular conformance job because the job is configured to set
IP_FAMILY
toipv6
but the test is expectingIPv6
to switch the template and e2e config. Other uses ofIP_FAMILY
that I can find all useipv6
, so this PR updates the test to look for that value.https://github.com/kubernetes/test-infra/blob/6ff24f80fad13b8a2f8b3a19a00e717c46964fee/config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml#L395-L396
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: