-
Notifications
You must be signed in to change notification settings - Fork 456
Add e2e test for managedclusteradopt controller #5786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @Copilot. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Co-authored-by: willie-yao <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: willie-yao <[email protected]>
// +build e2e | ||
|
||
/* | ||
Copyright 2024 The Kubernetes Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright 2024 The Kubernetes Authors. | |
Copyright 2025 The Kubernetes Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated copyright year to 2025 in commit 8b77a45.
adoptAnnotationValue = "true" | ||
) | ||
|
||
// AKSManagedClusterAdoptSpecInput contains the fields the required for testing managedclusteradopt controller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// AKSManagedClusterAdoptSpecInput contains the fields the required for testing managedclusteradopt controller. | |
// AKSManagedClusterAdoptSpecInput contains the fields required for testing the managedclusteradopt controller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the grammar by removing "the" before "required" in commit 8b77a45.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5786 +/- ##
=======================================
Coverage ? 52.80%
=======================================
Files ? 279
Lines ? 29602
Branches ? 0
=======================================
Hits ? 15632
Misses ? 13156
Partials ? 814 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@copilot retry |
Could you clarify what specifically you'd like me to retry? The e2e test implementation appears to be complete and the previous review comments have been addressed. Please let me know what aspect needs attention. |
@copilot Looks like there's an issue with signing the CLA.
Is it possible for you to sign the CLA agreement? It's a requirement to contribute to CNCF projects. |
I cannot sign CLA agreements as an AI agent. CLA signing requires a human contributor or legal entity. This administrative requirement would need to be handled by the repository maintainers or the human contributor who initiated this work. |
/close |
@willie-yao: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR adds comprehensive end-to-end testing for the
managedclusteradopt
controller, which was introduced in #5538 but only had unit tests.What this PR does
Adds a new e2e test that validates the complete adoption workflow for existing ASO ManagedCluster resources into CAPI management.
Key components:
test/e2e/aks_managedcluster_adopt.go
containingAKSManagedClusterAdoptSpec
azure_test.go
Test workflow:
ManagedCluster
andResourceGroup
directly (without CAPI)sigs.k8s.io/cluster-api-provider-azure-adopt: "true"
) to trigger the controllercluster.x-k8s.io/Cluster
infrastructure.cluster.x-k8s.io/AzureASOManagedCluster
infrastructure.cluster.x-k8s.io/AzureASOManagedControlPlane
The test follows existing patterns in the codebase and integrates seamlessly with the current e2e test suite, providing comprehensive coverage for the managedclusteradopt controller functionality that was missing.
Fixes #5585.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
metadata.google.internal
/usr/bin/../lib/google-cloud-sdk/platform/bundledpythonunix/bin/python3 /usr/bin/../lib/google-cloud-sdk/lib/gcloud.py config get-value project
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.