Skip to content

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Aug 21, 2025

What type of PR is this?
/kind failing-test

What this PR does / why we need it:

This PR updates the public IP prefix AKS e2e test to drop triggering the PublicIpPrefixOutOfIpAddressesForVMScaleSet error condition from the test. Until earlier this week, scaling a node pool in that state would converge to a successful state. Now AKS fails to scale the node pool, reporting that the backing VMSS doesn't exist.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://storage.googleapis.com/k8s-triage/index.html?date=2025-08-22&pr=1&text=aks_public_ip_prefix

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:


@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 21, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 21, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 21, 2025

/test pull-cluster-api-provider-azure-e2e-aks

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.94%. Comparing base (4ad8f96) to head (fe06842).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5833   +/-   ##
=======================================
  Coverage   46.94%   46.94%           
=======================================
  Files         279      279           
  Lines       29687    29687           
=======================================
  Hits        13936    13936           
  Misses      14938    14938           
  Partials      813      813           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 21, 2025

#5690

/test pull-cluster-api-provider-azure-e2e-aks

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 21, 2025

Looking for one more set of artifacts:

/test pull-cluster-api-provider-azure-e2e-aks

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 22, 2025

AFAICT, this is a change in behavior on the AKS side. Attempting to scale a node pool currently in PublicIpPrefixOutOfIpAddressesForVMScaleSet will fail because the backing VMSS doesn't exist and AKS doesn't seem to try to create it. I'm following up with AKS to see if this is a bug, but in the meantime I've updated this PR to drop triggering that error condition from the test.

/retitle Drop error condition from AKS node public IP prefix e2e test
/release-note-none

@k8s-ci-robot k8s-ci-robot changed the title Debug failing AKS e2e test Drop error condition from AKS node public IP prefix e2e test Aug 22, 2025
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 22, 2025
@nojnhuh nojnhuh marked this pull request as ready for review August 22, 2025 17:14
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 22, 2025

/kind failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Aug 22, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 24, 2025

Also failing on release branches:

/cherry-pick release-1.20
/cherry-pick release-1.21

@k8s-infra-cherrypick-robot

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.20, release-1.21 in new PRs and assign them to you.

In response to this:

Also failing on release branches:

/cherry-pick release-1.20
/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dff178a33b1f51dde12e618855aee0d0a5f6368a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit fc1c4aa into kubernetes-sigs:main Aug 24, 2025
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Aug 24, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Aug 24, 2025
@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #5836

In response to this:

Also failing on release branches:

/cherry-pick release-1.20
/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #5837

In response to this:

Also failing on release branches:

/cherry-pick release-1.20
/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh nojnhuh deleted the aks-debug branch August 25, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants