-
Notifications
You must be signed in to change notification settings - Fork 456
Drop error condition from AKS node public IP prefix e2e test #5833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request. |
/test pull-cluster-api-provider-azure-e2e-aks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5833 +/- ##
=======================================
Coverage 46.94% 46.94%
=======================================
Files 279 279
Lines 29687 29687
=======================================
Hits 13936 13936
Misses 14938 14938
Partials 813 813 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/test pull-cluster-api-provider-azure-e2e-aks |
Looking for one more set of artifacts: /test pull-cluster-api-provider-azure-e2e-aks |
AFAICT, this is a change in behavior on the AKS side. Attempting to scale a node pool currently in /retitle Drop error condition from AKS node public IP prefix e2e test |
/kind failing-test |
Also failing on release branches: /cherry-pick release-1.20 |
@nojnhuh: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: dff178a33b1f51dde12e618855aee0d0a5f6368a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nojnhuh: new pull request created: #5836 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@nojnhuh: new pull request created: #5837 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This PR updates the public IP prefix AKS e2e test to drop triggering the
PublicIpPrefixOutOfIpAddressesForVMScaleSet
error condition from the test. Until earlier this week, scaling a node pool in that state would converge to a successful state. Now AKS fails to scale the node pool, reporting that the backing VMSS doesn't exist.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes https://storage.googleapis.com/k8s-triage/index.html?date=2025-08-22&pr=1&text=aks_public_ip_prefix
Special notes for your reviewer:
TODOs:
Release note: