-
Notifications
You must be signed in to change notification settings - Fork 218
WIP: fix: panic on gke private cluster creation #1503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP: fix: panic on gke private cluster creation #1503
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
/hold Still validating that this approach is correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mjura: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, mjura, salasberryfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Carlos Salas <[email protected]>
3f6de04
to
f327c2a
Compare
New changes are detected. LGTM label has been removed. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind bug
What this PR does / why we need it:
#1416 introduced several changes to GCP API calls, as some fields have become deprecated. One of these changes causes a panic on a nil pointer as the controller is trying to assign a value to
NetworkConfig.DefaultEnablePrivateNodes
beforeNetworkConfig
is even initialized. This was not an issue before as this private nodes setting was not part ofNetworkConfig
butPrivateClusterConfig
.NOTE
Together with this fix, I'll try to add tests for this reconciler so bugs like this one can be easily detected.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1497
Special notes for your reviewer:
TODOs:
Release note: