Skip to content

🌱 add checker to validate conditions for v1beta2 #12111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sivchari
Copy link
Member

/area ci
/area testing
/area e2e-testing

close #11963

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/ci Issues or PRs related to ci area/testing Issues or PRs related to testing area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 21, 2025
@sivchari sivchari force-pushed the validate-conditions-v1beta2 branch from e107322 to 6dc0ee3 Compare April 21, 2025 08:04
@sivchari sivchari force-pushed the validate-conditions-v1beta2 branch from 6dc0ee3 to 0abf799 Compare April 29, 2025 13:49
@sivchari sivchari changed the title [WIP] add checker to validate conditions for v1beta2 🌱 add checker to validate conditions for v1beta2 Apr 29, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2025
@sivchari
Copy link
Member Author

/retest

@sivchari sivchari force-pushed the validate-conditions-v1beta2 branch from 0abf799 to aac7c75 Compare April 29, 2025 17:39
@sivchari sivchari force-pushed the validate-conditions-v1beta2 branch from aac7c75 to ab8f1eb Compare May 8, 2025 13:29
@sivchari
Copy link
Member Author

sivchari commented May 8, 2025

/close

@k8s-ci-robot
Copy link
Contributor

@sivchari: Closed this PR.

In response to this:

Got it, we don't use v1beta1 anymore, so this validation is never success.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sivchari
Copy link
Member Author

sivchari commented May 8, 2025

/reopen

@k8s-ci-robot k8s-ci-robot reopened this May 8, 2025
@k8s-ci-robot
Copy link
Contributor

@sivchari: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sivchari sivchari force-pushed the validate-conditions-v1beta2 branch from ab8f1eb to 3e41252 Compare May 8, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to ci area/e2e-testing Issues or PRs related to e2e testing area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate conditions at the end of e2e tests
2 participants