-
Notifications
You must be signed in to change notification settings - Fork 1.4k
✨Introduce NodeDeletionStrategy to allow drain node when deleting cluster #12142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Lubron Zhan <[email protected]>
Signed-off-by: Lubron Zhan <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Will fix the lint tmr |
/area machine |
Signed-off-by: Lubron Zhan <[email protected]>
Signed-off-by: Lubron Zhan <[email protected]>
293dcdc
to
a35d904
Compare
Signed-off-by: Lubron Zhan <[email protected]>
275cc74
to
9ed080e
Compare
Signed-off-by: Lubron Zhan <[email protected]>
cbedcb7
to
45806fc
Compare
Signed-off-by: Lubron Zhan <[email protected]>
45806fc
to
1b05729
Compare
The fuzzy conversion related test is failing because this field exist in v1beta2 api, not in v1beta1 api. Should I also add this field to v1beta1? |
@lubronzhan: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Introduce a
nodeDeletionStrategy
at cluster level, to allow opt-in node drain during cluster deletion. Keep the default behavior the same as before: delete machine without waiting for drain.Available option:
When implementing this, I noticed existing fields like
NodeDrainTimeout
atMachinePoolTopology/ControlPlaneTopology
, I felt like it might be more suitable to putnodeDeletionStrategy
along withNodeDrainTimeout
at the same level? But if that's the case, does it make more sense to also put it inside MD/MS/Machine level? And implement the propagation logic as part of #10753?Open to thoughts
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes ##9692