Skip to content

[release-1.10] 🐛 Fix continuous reconciles because of apiVersion differences in Cluster topology controller #12345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jun 11, 2025

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Manual cherry-pick of #12341

@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Jun 11, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 11, 2025
@sbueringer sbueringer changed the title [release-1.10] 🐛 Fix infinite reconcile because of apiVersions in Cluster topology controller [release-1.10] 🐛 Fix continuous reconciles because of apiVersion differences in Cluster topology controller Jun 11, 2025
@sbueringer sbueringer added the area/clusterclass Issues or PRs related to clusterclass label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jun 11, 2025
@sbueringer
Copy link
Member Author

/assign @fabriziopandini

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5d41f13b19e8dfea6a95a2ace4d0df0abda28028

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit e511e13 into kubernetes-sigs:release-1.10 Jun 11, 2025
31 checks passed
@sbueringer sbueringer deleted the pr-fix-infinite-reconcile-1.10 branch June 11, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants