🐛 Fix race condition in InMemoryMachine controller tests

[alimaazamat]

What this PR does / why we need it:
Error:
The controller returned ctrl.Result{} (no requeue) too early.
The test expects a requeue ctrl.Result{RequeueAfter: ...} until the provisioning duration has finished.

If res is equal to 0 then reconciliation will not be requeued, but it should be requeued and equal to 0.
if now < until then res != 0 and we requeue
if now >= until then res == 0 and we do not requeue (provisioned)

Problem:
Test setup took longer than provisioning duration causing the controller to think provisioning is completed when the test expected it to still be incomplete. Controller uses LastTransitionTime of NodeProvisionedCondition to determine if provisioning time is completed but this timestamp is out of date by the time test setup finishes.

Fix:
Added a helper function that updates the LastTransitionTime to current time right before calling the reconciler. Note that the helper function handles both current and deprecated status structures because we are migrating in between API versions until approximately August 2026.

Verification:
@mboersma and I ran this fix with a test script for multiple days and didn't get the error.

Which issue(s) this PR fixes:
Fixes #12301

[alimaazamat]

test result of d290d64:

I0625 07:08:03.191676   34585 inmemorymachine_backend.go:672] APIServer check: start=2025-06-25 07:08:00.844856 -0700 PDT m=+4.659283959, now=2025-06-25 07:08:03.191632 -0700 PDT m=+7.006113626, provisioningDuration=2s, until=2025-06-25 07:08:02.844856 -0700 PDT m=+6.659283959
I0625 07:08:03.201794   34585 mux.go:406] "APIServer instance added to workloadClusterListener" listenerName="foo" address="https://127.0.0.1:21100" podName="kube-apiserver-bar"
I0625 07:08:03.235570   34585 mux.go:494] "WorkloadClusterListener successfully started" listenerName="foo" address="https://127.0.0.1:21100"
--- FAIL: TestReconcileNormalApiServer (2.39s)
    --- FAIL: TestReconcileNormalApiServer/create_pod_if_Node_is_ready (2.39s)
        inmemorymachine_controller_test.go:626: 
            Expected
                <bool>: true
            to be false
FAIL
FAIL    sigs.k8s.io/cluster-api/test/infrastructure/docker/internal/controllers/backends/inmemory     7.717s
FAIL

[sbueringer]

/assign

[mboersma]

/area testing

[sbueringer]

Thank you very much!!

Sorry for the delay. Two nits, then happy to merge :)

[sbueringer]

Thanks again! That one was really annoying :)

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 542efc17fdf9753194cf86cfd9af01dde64d315a

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment