Skip to content

📖 Fix docs redirect for ClusterResourceSet #12443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

Surya-7890
Copy link
Contributor

What this PR does / why we need it:

The url for ClusterResourceSet points to an invalid page, as the feature is moved from experimental stage and made generally available. A redirect rule is written in the netlify.toml file to redirect the requests to the correct url.

Which issue(s) this PR fixes :
Fixes #12132

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 4, 2025
Copy link

linux-foundation-easycla bot commented Jul 4, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Surya-7890 / name: Surya (63f779f)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jul 4, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @Surya-7890!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Surya-7890. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 4, 2025
@Surya-7890 Surya-7890 force-pushed the fix/docs-redirect branch from 6b1f053 to 4007ba0 Compare July 4, 2025 12:39
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 4, 2025
The url for ClusterResourceSet points to an invalid page, as the feature is moved from experimental stage and made generally available
@mboersma
Copy link
Contributor

mboersma commented Jul 7, 2025

/ok-to-test
/area documentation
/release-note-none

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. area/documentation Issues or PRs related to documentation and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-area PR is missing an area label labels Jul 7, 2025
@mboersma
Copy link
Contributor

mboersma commented Jul 7, 2025

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

@Surya-7890 could you remove this line from the commit message?

Fixes: https://github.com/kubernetes-sigs/cluster-api/issues/12132

@sbueringer
Copy link
Member

Thx!

Change is fine otherwise

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@Surya-7890 Surya-7890 force-pushed the fix/docs-redirect branch from 4007ba0 to 63f779f Compare July 7, 2025 15:45
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 7, 2025
@Surya-7890
Copy link
Contributor Author

@mboersma @sbueringer Removed Fixes: #12132 from the commit message!

@sbueringer sbueringer changed the title 🐛 Fix docs redirect for ClusterResourceSet 📖 Fix docs redirect for ClusterResourceSet Jul 7, 2025
@sbueringer
Copy link
Member

Thx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1ec32a66cb88e303867d96d526d0ca2a6f201d34

@k8s-ci-robot k8s-ci-robot merged commit beddf81 into kubernetes-sigs:main Jul 7, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 7, 2025
@sbueringer
Copy link
Member

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #12457

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

Verified, works. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs redirect for ClusterResourceSet (experimental -> core feature)
5 participants