Skip to content

⚠️ Remove pointers from remaining pointer struct fields #12545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2025
Merged

⚠️ Remove pointers from remaining pointer struct fields #12545

merged 3 commits into from
Jul 31, 2025

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 29, 2025 •
edited
Loading

What this PR does / why we need it:
Newer version of KAL finds some more optional fields issues. This PR now drops pointers from all remaining pointer struct fields.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10852

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jul 29, 2025
@sbueringer sbueringer changed the title ⚠️ Drop some more pointers from pointer fields [WIP] ⚠️ Drop some more pointers from pointer fields Jul 29, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 29, 2025
@sbueringer sbueringer force-pushed the pr-drop-some-more-pointers branch 2 times, most recently from f1d2ebd to 33b88ed Compare July 29, 2025 20:44
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 29, 2025
@sbueringer sbueringer force-pushed the pr-drop-some-more-pointers branch 3 times, most recently from 6388c52 to 9cd905e Compare July 30, 2025 05:24
@Karthik-K-N
Copy link
Contributor

Hey @sbueringer given that optionallinter with omitzero checks has been merged in to KAL, can that be incorporated here

@sbueringer
Copy link
Member Author

sbueringer commented Jul 30, 2025 •
edited
Loading

This is basically what I'm doing by bumping to KAL main: a689623

I just can't actually merge that specific commit to bump KAL as KAL has some issues with required fields on main. But I'm coordinating with Joel

@Karthik-K-N
Copy link
Contributor

This is basically what I'm doing by bumping to KAL main: a689623

I just can't actually merge that specific commit to bump KAL as KAL has some issues with required fields on main. But I'm coordinating with Joel

sure thanks.

@sbueringer sbueringer force-pushed the pr-drop-some-more-pointers branch 12 times, most recently from bb6ba08 to 6f25925 Compare July 30, 2025 10:35
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

@sbueringer sbueringer force-pushed the pr-drop-some-more-pointers branch from edb95ec to 62b2986 Compare July 31, 2025 05:40
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

@sbueringer sbueringer mentioned this pull request Jul 31, 2025
Merged
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

JoelSpeed
JoelSpeed reviewed Jul 31, 2025
View reviewed changes
fabriziopandini
fabriziopandini reviewed Jul 31, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first part of comments

@sbueringer sbueringer mentioned this pull request Jul 31, 2025
Open
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

@JoelSpeed
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b519a9e6525789f0f5582c603982ef6e05d796d

fabriziopandini
fabriziopandini reviewed Jul 31, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second part of the review

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 31, 2025
@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 5eaaa34 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fabriziopandini
Copy link
Member

Awesome work!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b93913767146f14cbf6d1a91c82b4c4dd1403641

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3adb251 into kubernetes-sigs:main Jul 31, 2025
19 of 20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 31, 2025
@sbueringer sbueringer deleted the pr-drop-some-more-pointers branch July 31, 2025 18:45
@sbueringer sbueringer mentioned this pull request Aug 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

@g-gaston g-gaston Awaiting requested review from g-gaston

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @Karthik-K-N @JoelSpeed @k8s-ci-robot @fabriziopandini