-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Removed equinix provider #12229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed equinix provider #12229
Conversation
Hi @anshuman-agarwala. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/release-note-edit
contrib: removed Equinix Metal terraform support
docs/CNI/weave.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a network plugin for weave which should go as well.
Also contrib/ is not exactly supported so clearing that is not a problem but weave should should have a action required release note.
(and preferably in a separate PR, sorry, I hadn't noticed this file in the diff in the other ones).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the weave changes from here and created #12230 for handling weave network plugin removal, PTAL.
/ok-to-test |
d61d620
to
1cbf164
Compare
You need to run pre-commit to regenerate the docs index but otherwise looks good.
|
1cbf164
to
6e158b3
Compare
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anshuman-agarwala, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Removed equinix and weave providers as both are being/have been shuttered.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: